Uploaded image for project: 'JikesRVM'
  1. JikesRVM
  2. RVM-304

Improve performance of chacter encoder when encoding to and from arrays

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.3
    • Component/s: Runtime: Class Library
    • Labels:
      None

      Description

      Currently character set encoding/decoding is perfomed using CharBuffer.get/put and ByteBuffer.get/put, when these are backed up by arrays (the common case) this is burdensome. By using the hasArray check an array based copying loop should be implemented.

        Attachments

          Issue Links

            Activity

            Hide
            ianrogers Ian Rogers added a comment -

            This should improve the performance of the following benchmarks (the amount in brackets is the amount of time they currently spend in the encode loop): SpecJVM 98 Jack (2.5%), DaCapo antlr (6.42%), DaCapo lusearch (2.26%), DaCapo xalan (~2.5%).

            Show
            ianrogers Ian Rogers added a comment - This should improve the performance of the following benchmarks (the amount in brackets is the amount of time they currently spend in the encode loop): SpecJVM 98 Jack (2.5%), DaCapo antlr (6.42%), DaCapo lusearch (2.26%), DaCapo xalan (~2.5%).
            Hide
            ianrogers Ian Rogers added a comment -

            Patch committed in r13806.

            Show
            ianrogers Ian Rogers added a comment - Patch committed in r13806.

              People

              • Assignee:
                ianrogers Ian Rogers
                Reporter:
                ianrogers Ian Rogers
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: