Details

    • Type: Improvement
    • Status: Closed
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 2.9.2
    • Fix Version/s: 3.0
    • Component/s: Runtime
    • Labels:
      None

      Description

      Some code still assumes that the JTOC is not a constant. This adds noise to the code and creates confusion; as well, it can be an impediment when adding new code. In this improvement I will clean up the JTOC situation as much as possible, making it so that the native code assumes that it is a constant value that it acquires immediately upon loading, while the Java code has it as a baked-in constant. Notably, the baseline compiler on IA32 will no longer generate code to load the JTOC from the VM_Processor, and the VM_Processor will no longer have a JTOC field.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              pizlo Filip Pizlo added a comment -

              Patches separated - a well-cooked patch on the assembler is submitted under RVM-469.

              Show
              pizlo Filip Pizlo added a comment - Patches separated - a well-cooked patch on the assembler is submitted under RVM-469 .
              Hide
              pizlo Filip Pizlo added a comment -

              Included is a seemingly working patch. It works on IA32 and PPC. Only tested on Linux, but I think I was careful with the AIX issues.

              Show
              pizlo Filip Pizlo added a comment - Included is a seemingly working patch. It works on IA32 and PPC. Only tested on Linux, but I think I was careful with the AIX issues.
              Hide
              pizlo Filip Pizlo added a comment -

              NOTE: this patch will not work without the patch in RVM-469

              Show
              pizlo Filip Pizlo added a comment - NOTE: this patch will not work without the patch in RVM-469
              Hide
              dgrove David Grove added a comment -

              patch committed with minor adjustments due to code changes since patch submitted in r14228.

              Show
              dgrove David Grove added a comment - patch committed with minor adjustments due to code changes since patch submitted in r14228.
              Hide
              dgrove David Grove added a comment -

              reopening so I can modify fix target to 3.0

              Show
              dgrove David Grove added a comment - reopening so I can modify fix target to 3.0

                People

                • Assignee:
                  dgrove David Grove
                  Reporter:
                  pizlo Filip Pizlo
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: