Uploaded image for project: 'JikesRVM'
  1. JikesRVM
  2. RVM-756

Intel unnecessarily restricts boot image to be at addresses > 0x30000000

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0
    • Component/s: Runtime
    • Labels:
      None

      Description

      In the Intel libvm.c we do:

      unsigned int vp_hn; /* the high nibble of the vp address value */
      vp_hn = localVirtualProcessorAddress >> 28;
      if (vp_hn < 3 || !inRVMAddressSpace(localVirtualProcessorAddress))

      that asserts that the high nibble of objects must be above 0x30000000 making it impossible to fully use the heap. The high nibble tests should be removed.

        Gliffy Diagrams

          Attachments

            Activity

            dgrove David Grove created issue -
            Hide
            dgrove David Grove added a comment -

            I think the nibble based assertion is older than inRVMAddressSpace (ie, it predates the inRVMAddressSpace function being available).

            I don't object to removing it.

            For the truly paranoid, we could add an extra debugging test that the value in the TIB slot of *localVPA is equal to the TIB of the Processor class.

            Show
            dgrove David Grove added a comment - I think the nibble based assertion is older than inRVMAddressSpace (ie, it predates the inRVMAddressSpace function being available). I don't object to removing it. For the truly paranoid, we could add an extra debugging test that the value in the TIB slot of *localVPA is equal to the TIB of the Processor class.
            Hide
            ianrogers Ian Rogers added a comment -

            Fix in r15319.

            Show
            ianrogers Ian Rogers added a comment - Fix in r15319.
            dgrove David Grove made changes -
            Field Original Value New Value
            Workflow jira [ 17440 ] X10 Workflow [ 18732 ]
            dgrove David Grove made changes -
            Priority Major [ 6 ] Medium [ 3 ]

              People

              • Assignee:
                ianrogers Ian Rogers
                Reporter:
                ianrogers Ian Rogers
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: