Uploaded image for project: 'JikesRVM'
  1. JikesRVM
  2. RVM-900

aligned32Copy can copy 8 bytes when number of bytes to copy is 0

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.1.2
    • Component/s: Runtime
    • Labels:
      None
    • Environment:

      ia32 with SSE2 enabled

      Description

      when BYTES_IN_COPY == 8 then aligned32Copy in org.jikesrvm.runtime.Memory can incorrectly copy 8 bytes (4bytes + 4 bytes) when src is 4 byte aligned. The attached patch adds a series of assertions that verify the assumptions described in the Javadoc and an explicit check for if numBytes == 0

        Gliffy Diagrams

          Attachments

            Activity

            dgrove David Grove created issue -
            Hide
            l.hellyer@kent.ac.uk Laurence Hellyer added a comment -

            As noted by Daniel there is a commented out call to aligned32Copy at line 319 in Memory.java, uncommenting this call and removing the rest of this method passes the pre-commit tests but more validation (and probably an entire regression run) is needed.

            Show
            l.hellyer@kent.ac.uk Laurence Hellyer added a comment - As noted by Daniel there is a commented out call to aligned32Copy at line 319 in Memory.java, uncommenting this call and removing the rest of this method passes the pre-commit tests but more validation (and probably an entire regression run) is needed.
            Hide
            zyridium Daniel Frampton added a comment -

            Commited fix in r16017.

            Show
            zyridium Daniel Frampton added a comment - Commited fix in r16017.
            Hide
            dgrove David Grove added a comment -

            bulk close of all resolved issues in preparation for 3.1.3 release.

            Show
            dgrove David Grove added a comment - bulk close of all resolved issues in preparation for 3.1.3 release.
            dgrove David Grove made changes -
            Field Original Value New Value
            Workflow jira [ 17604 ] X10 Workflow [ 18683 ]
            dgrove David Grove made changes -
            Attachment RVM-900.patch [ 11142 ]
            dgrove David Grove made changes -
            Priority Major [ 6 ] Medium [ 3 ]

              People

              • Assignee:
                zyridium Daniel Frampton
                Reporter:
                l.hellyer@kent.ac.uk Laurence Hellyer
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: