Uploaded image for project: 'JikesRVM'
  1. JikesRVM
  2. RVM-962

Initial pass over the source code to remove duplicated comments

    Details

      Description

      The Jikes RVM source code currently contains many duplicated comments. This decreases both maintainablity and readability of the soure code. We should do the following:

      • change the source level in the build to Java 6 (@Override for implementations of interface methods was added in Java 6 and might not be supported in all Java 5 compilers)
      • add missing @Override annotations
      • remove duplicate and near duplicate comments

      See this thread for the original discussion.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ebrangs Erik Brangs added a comment -

            I've made an initial effort to remove duplicate comments and am currently preparing the patch set for submission.

            Show
            ebrangs Erik Brangs added a comment - I've made an initial effort to remove duplicate comments and am currently preparing the patch set for submission.
            Hide
            ebrangs Erik Brangs added a comment -

            The attached patch changes the source level to 1.6, adds @Override annotations and removes duplicated comments.

            It also contains a few minor comment changes.

            Show
            ebrangs Erik Brangs added a comment - The attached patch changes the source level to 1.6, adds @Override annotations and removes duplicated comments. It also contains a few minor comment changes.
            Hide
            dgrove David Grove added a comment -

            changesets applied cleanly; will commit later today after testing. Noticed that a number of PPC-specific static imports were also removed in one of the changesets; need to verify that is ok (and not Eclipse being overly aggressive about removing 'unused' imports).

            Show
            dgrove David Grove added a comment - changesets applied cleanly; will commit later today after testing. Noticed that a number of PPC-specific static imports were also removed in one of the changesets; need to verify that is ok (and not Eclipse being overly aggressive about removing 'unused' imports).
            Hide
            ebrangs Erik Brangs added a comment -

            Noticed that a number of PPC-specific static imports were also removed in one of the changesets; need to verify that is ok (and not Eclipse being overly aggressive about removing 'unused' imports).

            The removal of static imports is not ok; I'll prepare a new patch.

            Show
            ebrangs Erik Brangs added a comment - Noticed that a number of PPC-specific static imports were also removed in one of the changesets; need to verify that is ok (and not Eclipse being overly aggressive about removing 'unused' imports). The removal of static imports is not ok; I'll prepare a new patch.
            Hide
            dgrove David Grove added a comment -

            don't worry about it; I was able to selectively back out those parts of the patch. testing on ppc now.

            Show
            dgrove David Grove added a comment - don't worry about it; I was able to selectively back out those parts of the patch. testing on ppc now.
            Hide
            ebrangs Erik Brangs added a comment -

            Ok.

            By the way, my patch also removed some imports in org.jikesrvm.compilers.opt.regalloc.ppc.MIRSplitRanges. The class does not seem to be used anywhere and could be removed.

            Show
            ebrangs Erik Brangs added a comment - Ok. By the way, my patch also removed some imports in org.jikesrvm.compilers.opt.regalloc.ppc.MIRSplitRanges . The class does not seem to be used anywhere and could be removed.
            Hide
            dgrove David Grove added a comment -

            merged and pushed changesets from patch after restoring removed import statements.

            Show
            dgrove David Grove added a comment - merged and pushed changesets from patch after restoring removed import statements.
            Hide
            dgrove David Grove added a comment -

            bulk close of all resolved issues in preparation for 3.1.3 release.

            Show
            dgrove David Grove added a comment - bulk close of all resolved issues in preparation for 3.1.3 release.

              People

              • Assignee:
                dgrove David Grove
                Reporter:
                ebrangs Erik Brangs
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: